Repository navigation
Conversation
Return nil instead of raising an error when a record has no identifiers, and add a regression test.
This branch should return record with null isbns, production will return error for this query:
```
{
recordId(id: "alma:9935045653306761") {
title
isbns
}
}
```
https://mitlibraries.atlassian.net/browse/TIMX-746
Sentry: TIMDEX-6Q
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change safely handles missing identifier data and adds regression coverage for the absent-key case, with no active review issues identified.
No open issues 🎉
What changed in this PR
Updates deprecated identifier field resolvers so records without an identifiers key return null instead of raising an error, with regression coverage for the missing-key case.
Changes:
- Safely handles missing identifier data in deprecated identifier accessors.
- Adds a regression test verifying
isbnsreturnsnilwhen identifiers are absent.
| File | Description |
|---|---|
| test/graphql/types/record_type_test.rb | Adds regression coverage verifying that isbns returns nil when the record lacks an identifiers key. |
| app/graphql/types/record_type.rb | Makes deprecated identifier field resolution safe when identifier data is missing. |
Review effort: Lite
jazairi
approved these changes
Nov 12, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return nil instead of raising an error when a record has no identifiers, and add a regression test.
This branch should return record with null isbns, production will return error for this query:
https://mitlibraries.atlassian.net/browse/TIMX-746 Sentry: TIMDEX-6Q
Developer
Code Reviewer
(not just this pull request message)
Requires database migrations?
NO
Includes new or updated dependencies?
NO